io.github.bjornj12/golf-coach

What we checked

Six static checks, weighted by risk. Every result reflects only what could be observed in the published package and repository — never intent.

• Injection surface

  unscannable25% of grade

  Tool descriptions/manifest scanned for instruction-injection patterns (imperatives at the model, hidden text, 'ignore previous', data-exfil URLs).

  No tool descriptions, server instructions, prompts, or resources were fetched; nothing to scan for injection.

• Supply chain

  fail25% of grade

  Package provenance: namespace verification, repo linkage, maintainer count, account age, postinstall scripts, typosquat distance.

  Python build script executes at build time: network call in build script

• Credential hygiene

  warn15% of grade

  How the server takes secrets (env vs plaintext config vs hardcoded); secrets appearing in tool schemas.

  tests/test_server.py: assigns a literal to secret (supe…wt (len 16)) — non-provider secret literal; prefer environment intake. Reads secrets from the environment (e.g. scripts/release.sh) — the recommended intake shape.

• Permission scope

  fail15% of grade

  Declared tools vs. breadth (filesystem, network, exec); flags shell-exec and unbounded filesystem access.

  HIGH: shell/exec capability AND network egress together — download-and-execute risk (src/golf_coach/login.py: subprocess.* call; src/golf_coach/client.py: outbound HTTP/socket call). HIGH: shell/exec capability AND destructive filesystem writes together (src/golf_coach/login.py: subprocess.* call; src/golf_coach/storage.py: destructive filesystem call (shutil.rmtree/os.remove/etc.)). discloses shell/exec capability: src/golf_coach/login.py: subprocess.* call discloses broad/destructive filesystem access: src/golf_coach/storage.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) discloses broad/destructive filesystem access: src/golf_coach/visualize.py: open(…, 'w'/'a'/'x') write-mode file access Capability DISCLOSURE, not a verdict: static analysis sees the primitive is present and reachable, not whether its use is attacker-controlled.

• Version behavior

  fail10% of grade

  Diff of tool definitions between versions; new permissions or changed descriptions in a patch release (the postmark-mcp class).

  vs prior 0.6.0 (minor bump): new capability primitive(s) in source: fs-write, http-client, subprocess; new hardcoded outbound host/BCC destination(s): attacker.example, evil.com, example.com, hackmotion.com, login.trackmangolf.com, nottrackmangolf.com, pypi.org, staging.trackman.example, trackmangolf.com.evil.com, www.apple.com, www.youtube.com, y.

• Transport config

  warn10% of grade

  Remote servers: TLS and auth mode (none/token/OAuth). Local servers: whether the manifest indicates it phones home.

  manifest/source references analytics behavior — disclosure