io.github.hjqcan/goodmemory

What we checked

Six static checks, weighted by risk. Every result reflects only what could be observed in the published package and repository — never intent.

• Injection surface

  unscannable25% of grade

  Tool descriptions/manifest scanned for instruction-injection patterns (imperatives at the model, hidden text, 'ignore previous', data-exfil URLs).

  No tool descriptions, server instructions, prompts, or resources were fetched; nothing to scan for injection.

• Supply chain

  warn25% of grade

  Package provenance: namespace verification, repo linkage, maintainer count, account age, postinstall scripts, typosquat distance.

  dependency "ai" is edit-distance 2 from popular package "chai" (typosquat candidate)

• Credential hygiene

  pass15% of grade

  How the server takes secrets (env vs plaintext config vs hardcoded); secrets appearing in tool schemas.

  Reads secrets from the environment (e.g. scripts/goodmemory-cli.js) — the recommended intake shape. PASS = no static red flag; static analysis cannot prove the code honors env-based secret handling at runtime.

• Permission scope

  fail15% of grade

  Declared tools vs. breadth (filesystem, network, exec); flags shell-exec and unbounded filesystem access.

  HIGH: shell/exec capability AND network egress together — download-and-execute risk (scripts/goodmemory-cli.js: imports child_process and calls exec/spawn; src/http/index.ts: outbound HTTP/socket call). HIGH: shell/exec capability AND destructive filesystem writes together (scripts/goodmemory-cli.js: imports child_process and calls exec/spawn; scripts/goodmemory-cli.js: path traversal ('../') combined with file access). discloses shell/exec capability: scripts/goodmemory-cli.js: imports child_process and calls exec/spawn discloses shell/exec capability: scripts/goodmemory-http-bridge.js: imports child_process and calls exec/spawn discloses shell/exec capability: scripts/goodmemory-mcp.js: imports child_process and calls exec/spawn discloses shell/exec capability: src/storage/sqliteRuntime.ts: imports child_process and calls exec/spawn discloses broad/destructive filesystem access: scripts/goodmemory-cli.js: path traversal ('../') combined with file access discloses broad/destructive filesystem access: scripts/goodmemory-http-bridge.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/abstention.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/contradiction.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/extraction.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/instruction.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/preference.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/answer/operations/summary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/capabilityDescriptor.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/contracts.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/hostActionAssessmentOps.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/integrationSupport.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/internalRetrievalRollout.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/api/runtimeResolution.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/bootstrap/hostBootstrap.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/cli.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/answer-generator.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/behavioral-adaptation.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/contracts.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/dataset.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/implicit-behavior.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/implicitmembench-research.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/judge-model.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/longmemeval.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/phase27.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/phase59.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/runners.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/eval/strategy-promotion-gate.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/evolution/behavioralPolicy.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/evolution/gates.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/evolution/rawBehavioralExemplars.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/evolution/reviewer.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/evolution/salvage.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/governance/markdownArtifacts.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/host/contracts.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/host/preActionPolicy.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/host/public.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/http/index.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostActionRuntime.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostConfigValidation.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostHookConfig.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostHookRuntime.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostInstall.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostMcpConfig.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostMcpServer.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostProgressiveRecall.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostWritebackAuditLedger.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/hostWritebackRuntime.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/install/standaloneMcpContext.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/language/chinese.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/language/english.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/language/service.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/maintenance/runner.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/progressive/recall.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/provider/ai-sdk-runtime.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/provider/memory-extractor.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/provider/recall-router.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/assistant.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/contextBuilder.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/router.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/scoring.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selection.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectionRunContext.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectionSlot.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/aggregate.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/contradictionRules/multiFacetGroups.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/instructionRules/legalTermsExplanation.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/recordSelection.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/selectionContext.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderInformationExtraction.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/academicMentorshipSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/estatePlanningSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/fictionBookBudgetSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/hiringComplianceSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/hiringProcessSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/instructionTopics.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/personalStatementMentorSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/professionalDevelopmentProjectSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/readingGoalsStrategySummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/reasoningRules.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/relationshipFinancialManagementSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/researchWritingCollaborationSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/studyAbroadSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/timeStressCollaborationSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/weatherSuggestionSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderRules/webProjectIssueResolutionSummary.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderSummaryTopical.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderTemporal.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/sourceOrderTemporalInterval.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/aiEthicsWebinar.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/areaCalculationAccuracy.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/estateTaxRate.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/executiveProducerInterviews.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/finalDecisionMeeting.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/holidayGiftBudget.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/probabilityStudyHours.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/probateTimeline.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/prototypeBudget.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/snackBudget.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/winterReadingChallenge.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/writingGroupDeadline.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/recall/selectors/updateSeriesRules/zoteroSources.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/remember/engine.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/remember/episodes.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/runtime-viewer/public.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/runtime/contextService.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/storage/postgres.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/storage/sqlite.ts: path traversal ('../') combined with file access discloses broad/destructive filesystem access: src/testing/scenarioReplay.ts: path traversal ('../') combined with file access Capability DISCLOSURE, not a verdict: static analysis sees the primitive is present and reachable, not whether its use is attacker-controlled.

• Version behavior

  unscannable10% of grade

  Diff of tool definitions between versions; new permissions or changed descriptions in a patch release (the postmark-mcp class).

  no prior version to diff (first sight of io.github.hjqcan/[email protected]); version-drift / rug-pull cannot be evaluated. Cold-start risk is covered by point-in-time checks (injection_surface, supply_chain, credential_hygiene), not here.

• Transport config

  warn10% of grade

  Remote servers: TLS and auth mode (none/token/OAuth). Local servers: whether the manifest indicates it phones home.

  manifest/source references tracking behavior — disclosure