io.github.mayor-modder/cities2-mcp

What we checked

Six static checks, weighted by risk. Every result reflects only what could be observed in the published package and repository — never intent.

• Injection surface

  unscannable25% of grade

  Tool descriptions/manifest scanned for instruction-injection patterns (imperatives at the model, hidden text, 'ignore previous', data-exfil URLs).

  No tool descriptions, server instructions, prompts, or resources were fetched; nothing to scan for injection.

• Supply chain

  pass25% of grade

  Package provenance: namespace verification, repo linkage, maintainer count, account age, postinstall scripts, typosquat distance.

  Python build script has no build-time network/exec; repository linkage verified

• Credential hygiene

  pass15% of grade

  How the server takes secrets (env vs plaintext config vs hardcoded); secrets appearing in tool schemas.

  Reads secrets from the environment (e.g. cities2_mcp/game_encyclopedia.py) — the recommended intake shape. PASS = no static red flag; static analysis cannot prove the code honors env-based secret handling at runtime.

• Permission scope

  fail15% of grade

  Declared tools vs. breadth (filesystem, network, exec); flags shell-exec and unbounded filesystem access.

  HIGH: shell/exec capability AND destructive filesystem writes together (cities2_mcp/build_runner.py: subprocess.* call; cities2_mcp/agent_assets.py: destructive filesystem call (shutil.rmtree/os.remove/etc.)). discloses shell/exec capability: cities2_mcp/build_runner.py: subprocess.* call discloses shell/exec capability: cities2_mcp/release_version.py: subprocess.* call discloses shell/exec capability: tests/smoke_mcp.py: subprocess.* call discloses shell/exec capability: tests/test_packaging.py: subprocess.* call discloses shell/exec capability: tests/test_release_version.py: subprocess.* call discloses shell/exec capability: tests/test_scaffold.py: subprocess.* call discloses broad/destructive filesystem access: cities2_mcp/agent_assets.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) discloses broad/destructive filesystem access: cities2_mcp/plugin_packages.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) discloses broad/destructive filesystem access: cities2_mcp/plugin_packages.py: path traversal ('../') combined with file access discloses broad/destructive filesystem access: tests/smoke_mcp.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) discloses broad/destructive filesystem access: tests/test_analyzer.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) discloses broad/destructive filesystem access: tests/test_corpus_source_links.py: path traversal ('../') combined with file access discloses broad/destructive filesystem access: tests/test_eval_claude_adapter.py: path traversal ('../') combined with file access discloses broad/destructive filesystem access: tests/test_eval_codex_adapter.py: path traversal ('../') combined with file access discloses broad/destructive filesystem access: tests/test_scaffold.py: destructive filesystem call (shutil.rmtree/os.remove/etc.) Capability DISCLOSURE, not a verdict: static analysis sees the primitive is present and reachable, not whether its use is attacker-controlled.

• Version behavior

  fail10% of grade

  Diff of tool definitions between versions; new permissions or changed descriptions in a patch release (the postmark-mcp class).

  vs prior 0.2.2 (patch bump): new capability primitive(s) in source: child_process, fs-write, subprocess; new hardcoded outbound host/BCC destination(s): central.paradoxwikis.com, cities2.paradoxwikis.com, creativecommons.org, cs2.paradoxwikis.com, example.test, pypi.org, static.modelcontextprotocol.io.

• Transport config

  warn10% of grade

  Remote servers: TLS and auth mode (none/token/OAuth). Local servers: whether the manifest indicates it phones home.

  manifest/source references telemetry behavior — disclosure